D8243: Implement support for categories on KfilesPlacesView

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> renatoo wrote in kfileplacesview.cpp:169
> Humm I did not know about this opt.index property.  Did some debug here and it is always -1 .
> 
> Sorry but I am not sure why should I care about opt.index? Checking the "index" arg is not enough?
> 
> I am checking it with "indexIsSectionHeader"  which checks if we should draw the section header or not. (it will return "true" for index 0)

I think in to move away from workarounds. Cause we want to draw header only ones i you ask to check a QStyleOptionViewItem index if you can use it insetad of dragcount.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure, ervin
Cc: mlaurent, ervin, anthonyfieroni, cfeck, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171013/5b3c820a/attachment-0001.html>