D8243: Implement support for categories on KfilesPlacesView

Renato Oliveira Filho noreply at phabricator.kde.org
Thu Oct 12 18:52:14 UTC 2017


renatoo marked 2 inline comments as done.
renatoo added inline comments.

INLINE COMMENTS

> renatoo wrote in kfileplacesview.cpp:424
> I need a way query the header size height from "pointIsHeaderArea" to know if the user clicked on header or in the real item. Since I do not have access from "QStyleOptionViewItem" from there, I need to store it in a var to use it late if necessary.
> 
> I do not love the way that is implemented but, I can not find a better way to implement that.

Ok instead of use QStyleOptionViewItem information to check the font size of the header. Now I use QApplication::font, this give me flexibility to check the header size at any part of the code.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure, ervin
Cc: mlaurent, ervin, anthonyfieroni, cfeck, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171012/3cd2b1e0/attachment.html>


More information about the Kde-frameworks-devel mailing list