D8243: Implement support for categories on KfilesPlacesView

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kfileplacesview.cpp:104
> +
> +    int m_sectionRole;
> +

const

> kfileplacesview.cpp:1065-1066
>      const int maxWidth = q->viewport()->width() - textWidth - 4 * margin - 1;
> -    const int maxHeight = ((q->height() - (fm.height() / 2) * rowCount) / rowCount) - 1;
> +    int maxHeight = ((q->height() - (fm.height() / 2) * rowCount) / rowCount) - 1;
> +    maxHeight = sectionsCount() * fm.height();
>  

So if second line is correct why not remove first one?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure
Cc: anthonyfieroni, cfeck, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171012/250b53a3/attachment.html>