D8207: Use https for KDE urls
Kevin Funk
noreply at phabricator.kde.org
Sun Oct 8 21:55:12 UTC 2017
kfunk added a comment.
In https://phabricator.kde.org/D8207#153510, @mpyne wrote:
> I support the idea, but I think there's a few more spots where we can convert http:// to https://. I ran `ag --only-matching --no-heading 'http:.*k.*\.org'` in the kcoreaddons source directory, with the current version of this patch already applied, and got the following output:
>
> src/lib/kaboutdata.h:811:http://". "http://kate.kde.org
Bad match -- this is just an apidocs example how to format the url. I left this out.
I've now fixed all the http://kde.org urls as well. Didn't touch the others though -- those are out of our control.
> Of these, the XML might be an issue (though I doubt it), and I'm not sure if koffice.org is still current. But the autotest sample .desktop files can be changed, which will impact the kpluginmetadatatest also.
>
> In the meantime I've verified that the current patch passes the testsuite on my machine as well.
+1, same here.
Pushed now.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D8207
To: kfunk, apol
Cc: apol, mpyne, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171008/10d00db0/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list