D6832: Integrate new file ioslave in KIO job

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> job_base.h:311
> +     *
> +     * @since 5.39
> +     **/

You can use @since 5.40 everywhere...

> job_base.h:317
> +     * When set, notifies the slave that application/job does not want privilege execution.
> +     * So in case of failure due to insufficint privileges show an error.
> +     *

typo: insufficient

I would add "without attempting to run the operation as root first".

> job_base.h:320
> +     * @since 5.39
> +     **/
> +    NoPrivilegeExecution = 16

It's usually just */ on this line (single star)

REVISION DETAIL
  https://phabricator.kde.org/D6832

To: chinmoyr, dfaure, #frameworks
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171007/5047637c/attachment.html>