D8060: allow to set a custom palette instead of colorSets

[Jean-Baptiste Mardelle]

mardelle added a comment.


  Just to let you know, these last 2 commits to KIconThemes break the icon coloring in existing apps like Kdenlive and KDevelop.
  Previously, in a KXmlGuiWindow, doing:
  
  QPalette plt = KColorScheme::createApplicationPalette(config);
  setPalette(plt);
  qApp->setPalette(palette());
  
  Made the icon theme adapt to the palette. The recent commits break this and it is now required to add :
  
  KIconLoader::global()->setCustomPalette(plt);
  
  To make icon color theming work in existing apps that allow color theme switch. 
  Regression can be easily tested with KDevelop or Kdenlive using the "Color theme" menu from Settings

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D8060

To: mart, dfaure, #frameworks, rikmills, davidedmundson
Cc: mardelle, davidedmundson, broulik, cfeck, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171006/0b1c463a/attachment.html>