D7750: fix crash when more than one instances of ExtractorCollection are destructed

David Faure noreply at phabricator.kde.org
Sun Oct 1 13:50:40 UTC 2017


dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Looks good. To nitpick, setAutoDeletePlugin(true) would have been clearer IMHO.
  
  (Shared sounds like shared_ptr i.e. refcounting, which isn't the case here, it's just autodelete=off)

REPOSITORY
  R286 KFileMetaData

BRANCH
  fixPluginDelete

REVISION DETAIL
  https://phabricator.kde.org/D7750

To: mgallien, #frameworks, dfaure
Cc: dfaure, anthonyfieroni
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171001/117933b8/attachment.html>


More information about the Kde-frameworks-devel mailing list