D9048: [kglobalaccel] Drop QWidget dependency

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:36
>  set(REQUIRED_QT_VERSION 5.7.0)
> -find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED DBus Widgets)
> +find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED DBus)
>  

lib still uses widgets, I doubt this will compile.
If it does, it's because it's pulled in from something else.

(in fact the runtime links against them too, but for a hidden window to capture key events)

> main.cpp:29
>  #include <QDebug>
> -#include <QGuiApplication>
> +#include <QApplication>
>  #include <QIcon>

I don't understand, this would re-introduce a widgets dependency.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D9048

To: anthonyfieroni, davidedmundson, apol
Cc: broulik, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171129/cc54dbcf/attachment.html>