D8495: Faster UDevManager::devicesFromQuery

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Nov 28 13:24:46 UTC 2017


broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> udevmanager.cpp:182
> +        const UdevQt::DeviceList deviceList = d->m_client->allDevices();
> +        Q_FOREACH (const UdevQt::Device &dev, deviceList) {
> +            UDevDevice device(dev);

If you're getting a `const` list now, you could also use range-for

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8495

To: davidedmundson, broulik
Cc: broulik, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171128/a1c05701/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list