D9004: Input validation of SubJobs

Anthony Fieroni noreply at phabricator.kde.org
Mon Nov 27 19:40:33 UTC 2017


anthonyfieroni added inline comments.

INLINE COMMENTS

> kcompositejob.cpp:104
>          setErrorText(job->errorText());
> -        emitResult();
> +        // Finish this KCompositeJob only if it has no subjobs
> +        if (d->subjobs.isEmpty()) {

David mean to finish job on first error, i.e. to not change this behavior. Can you verify that without empty check here and in KIO bug is fixed?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9004

To: jtamate, #frameworks, dfaure, anthonyfieroni
Cc: anthonyfieroni
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171127/723a8deb/attachment.html>


More information about the Kde-frameworks-devel mailing list