D9018: Don't cause circular linking on Windows

[Dan Leinir Turthra Jensen]

leinir created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  When building plugins, don't arbitrarily rename the output files (as this will occasionally result in circular dependencies).
  
  In this review from three and a half years ago <https://git.reviewboard.kde.org/r/118084/>, the Sonnet plugins were moved into a subdirectory, which was great. They were, however, also renamed at the same time, which resulted in some (and specifically the aspell plugin) being named the same as the library they should be linked against. End result: Spell checking has not worked on Windows for three and a half years.

TEST PLAN
  With these properties set, the plugins fail to load on Windows due to circular dependencies
  
  Without them (that is, with this patch), the plugins load

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D9018

AFFECTED FILES
  src/plugins/aspell/CMakeLists.txt
  src/plugins/enchant/CMakeLists.txt
  src/plugins/hspell/CMakeLists.txt
  src/plugins/hunspell/CMakeLists.txt
  src/plugins/nsspellchecker/CMakeLists.txt
  src/plugins/voikko/CMakeLists.txt

To: leinir
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171127/d851bada/attachment.html>