D9012: Revert "Detach before setting the d pointer"

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: whiting, leinir, apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  This reverts commits https://phabricator.kde.org/R304:04cc49c71bdb948e06ccae2d97d7cc1a1d2f62af as well
  as the follow-up partial fix https://phabricator.kde.org/R304:c32c8d002e1216373560c94738841a7a5e1b976b
  
  The whole internal data sync'ing design of the KNewStuff core library
  relies on EntryInternal instances explicitely sharing the data.
  Changing only EntryInternal to implicitly shared data broke things.
  And changed behaviour of that class also for any 3rd-party consumers.
  
  BUG: 386156

REPOSITORY
  R304 KNewStuff

BRANCH
  unbreakEntryInternalDataSyncing

REVISION DETAIL
  https://phabricator.kde.org/D9012

AFFECTED FILES
  src/core/entryinternal.cpp

To: kossebau, whiting, leinir, apol
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171126/284fd72d/attachment.html>