D9004: Input validation of SubJobs

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> dfaure wrote in kcompositejob.cpp:102
> When a subclass calls this slotResult implementation, they expect the behaviour of "finish with an error if the subjob had an error".
> 
> But NOT emitResult in the normal case (no error), since we might want to continue by creating another subjob.
> 
> I'm still missing a proper explanation of what's happening and what shouldn't happen.

Yes, i saw in the code but i understand it a bit strange.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9004

To: jtamate, #frameworks, dfaure, anthonyfieroni
Cc: anthonyfieroni
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171126/988a99f1/attachment.html>