D9004: Input validation of SubJobs

David Faure noreply at phabricator.kde.org
Sun Nov 26 17:28:06 UTC 2017


dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Just do another arc diff, if your uploaded patch isn't the latest one.

INLINE COMMENTS

> anthonyfieroni wrote in kcompositejob.cpp:102
> Here after remove last job it should emit no?

No no no this is all wrong, please don't change the logic here.
After a subjob is done, we might want to start another one.
Most KIO jobs work like that.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D9004

To: jtamate, #frameworks, dfaure, anthonyfieroni
Cc: anthonyfieroni
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171126/9c09a1ed/attachment.html>


More information about the Kde-frameworks-devel mailing list