D9004: Input validation of SubJobs

[David Faure]

dfaure added a comment.


  Ah wait this could be made faster to avoid the double lookup.
  
    if (d->subjobs.removeAll(job) > 0) {
        job->setParent(nullptr);
        return true;
    }
    return false;
  
  (and then we don't even need the job==nullptr check, that's included in the removeAll check)

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9004

To: jtamate, #frameworks, dfaure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171126/5048eab3/attachment.html>