D8999: KJob: add start(int delay) method

[René J.V. Bertin]

rjvbb marked 2 inline comments as done.
rjvbb added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kjob.cpp:98
> Use new syntax
> 
>   QTimer::singleShot(delay, this, &KJob::start);

So KJob::emitSpeed() doesn't use the "old" syntax for compatibility reasons?

> anthonyfieroni wrote in kjob.h:182
> You cannot add a virtual function it will break ABI compatibility.

Duh, that s*kcs ... (I knew about making existing methods virtual).

I'm not entirely certain if this has to be a virtual method but I guess there's no other choice.

At least this removes any doubts as to whether I should provide a default implementation =)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D8999

To: rjvbb, dfaure
Cc: anthonyfieroni, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171125/8d363343/attachment-0001.html>