D9001: Possible solution to bug 364039

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  This is my first phabricator revision, I hope I'm doing it right.
  
  First part of the patch in kcoreaddons. Don't remove a child if it is not in the list of children.
  Second part in kio. Don't emitResult, that will delete the job, if the job has subjobs.
  
  It fixes the crash for me as I was able to reproduce it and I can't.
  
  I hope it doesn't introduce any leak.

TEST PLAN
  Using a filesystem where you can not change file rights (for example ntfs), move a file from a ext4 folder to that filesystem. The "can not change permissions" dialog appears, with options to retry or cancel. Press retry, a new dialog saying it can not move the original file because it does not exists appears, press retry more than 3 times, then cancel. Before I got a crash, now I can do this several times without crash.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9001

AFFECTED FILES
  src/core/filecopyjob.cpp
  src/lib/jobs/kcompositejob.cpp

To: jtamate, #frameworks, dfaure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171125/c0814167/attachment-0001.html>