D8450: User can now hide an entire places group from KFilePlacesView

Franck Arrecot noreply at phabricator.kde.org
Fri Nov 24 14:36:56 UTC 2017


franckarrecot added inline comments.

INLINE COMMENTS

> ervin wrote in kfileplacesview.cpp:863-866
> I still stand by that comment, I'd welcome a patch on top of that one to reduce that duplication please.

Oki I add that to my list :-)

> ervin wrote in kfileplacesview.cpp:298
> That smells std::transform instead of the hand crafted loop at least.

good idea

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8450

To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent
Cc: mwolff, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171124/ecaa0e0b/attachment.html>


More information about the Kde-frameworks-devel mailing list