D8367: Hidding place groups implementation in KFilePlacesModel

[Franck Arrecot]

franckarrecot added inline comments.

INLINE COMMENTS

> ervin wrote in kfileplacesmodel.cpp:870
> Why not naming the variable isGroupHidden and use the :: prefix on the function call like milian proposed?

Because it wouldn't compile without the whole KFIlePlacesModel:: prefix, so I end up going for variable renaming, seemed cleaner

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8367

To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent
Cc: mwolff, ngraham, mlaurent, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171124/43c0c72b/attachment.html>