D8332: Added baloo urls into places model
David Faure
noreply at phabricator.kde.org
Wed Nov 22 22:36:04 UTC 2017
dfaure added inline comments.
INLINE COMMENTS
> kfileplacesviewtest.cpp:70
> +
> +void KFilePlacesViewTest::testUrlChangedContaisConvertedUrl_data()
> +{
typo: Contains.
I would just have called it `testUrlChanged` because it also checks that it's emitted, not just what the emitted value is :)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin, mlaurent, dfaure, mwolff
Cc: mwolff, dfaure, ervin, usta, mlaurent, dvratil, ngraham, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171122/fa013ebe/attachment.html>
More information about the Kde-frameworks-devel
mailing list