D8332: Added baloo urls into places model

[David Faure]

dfaure accepted this revision.
dfaure added inline comments.

INLINE COMMENTS

> kfileplacesviewtest.cpp:56
> +    // Ensure we'll have a clean bookmark file to start
> +    QFile::remove(bookmarksFile());
> +

You could just call cleanupTestCase() here, I usually do that too. Cleanup at start, cleanup at end.

> kfileplacesviewtest.cpp:102
> +
> +void KFilePlacesViewTest::testConvertUrl()
> +{

Isn't this rather a test for urlChanged()?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8332

To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin, mlaurent, dfaure, mwolff
Cc: mwolff, dfaure, ervin, usta, mlaurent, dvratil, ngraham, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171122/aab49c35/attachment.html>