D8367: Hidding place groups implementation in KFilePlacesModel

Franck Arrecot noreply at phabricator.kde.org
Wed Nov 22 11:35:28 UTC 2017


franckarrecot added a comment.


  precision on useless comment

INLINE COMMENTS

> franckarrecot wrote in kfileplacesmodel.cpp:257
> it is currently not needed here since each change an object metadata ( eg : item isHidden metadata ) would trigger a loadBookmarkList(). 
> And in this code we make sure to change the hidden state of item if it conflict with their parent.
> 
> However I think it could help future reader to get the intention if I added this.

forget that part, old comment stored I don't know how from old revision...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8367

To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent
Cc: mwolff, ngraham, mlaurent, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171122/65aff7ae/attachment.html>


More information about the Kde-frameworks-devel mailing list