D8367: Hidding place groups implementation in KFilePlacesModel

[Franck Arrecot]

franckarrecot commandeered this revision.
franckarrecot edited reviewers, added: mlaurent; removed: franckarrecot.
franckarrecot added a comment.


  taking ownership back to fix comments, thanks Laurent for taking care of it :-)

INLINE COMMENTS

> renatoo wrote in kfileplacesmodel.cpp:257
> should this  check if the group which the index belongs is hider or not?
> 
> Something like:
> 
> return (data(index, HiddenRole).toBool() ||  isPlaceGroupHidden(index));

it is currently not needed here since each change an object metadata ( eg : item isHidden metadata ) would trigger a loadBookmarkList(). 
And in this code we make sure to change the hidden state of item if it conflict with their parent.

However I think it could help future reader to get the intention if I added this.

REVISION DETAIL
  https://phabricator.kde.org/D8367

To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent
Cc: mwolff, ngraham, mlaurent, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171122/bdac921c/attachment.html>