D8862: Extend KFilePlacesModel API

David Faure noreply at phabricator.kde.org
Tue Nov 21 22:22:13 UTC 2017


dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kfileplacesmodel.cpp:913
>  
> +bool KFilePlacesModel::movePlace(int row, int before)
> +{

This should get its own unittest, especially since there are lots of edge cases.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8862

To: renatoo, dfaure, mwolff
Cc: mwolff, dfaure, ngraham, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171121/4a9f1d10/attachment.html>


More information about the Kde-frameworks-devel mailing list