D8923: Offer QWindow API for KJobWidgets:: decorators

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Nov 21 11:24:34 UTC 2017


apol marked an inline comment as done.
apol added inline comments.

INLINE COMMENTS

> kfunk wrote in kjobwidgets.cpp:67
> `WId` is a `quintptr`: `src/gui/kernel/qwindowdefs.h:99:typedef QT_PREPEND_NAMESPACE(quintptr) WId;`
> 
> Besides: `QVariant::fromValue(window->winId())` should work just fine, or?

Note I didn't change any code, I just moved it around.

Removing the cast still seems to work, so I'll do that.

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D8923

To: apol, #frameworks
Cc: kfunk
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171121/0b79d9cd/attachment.html>


More information about the Kde-frameworks-devel mailing list