D8923: Offer QWindow API for KJobWidgets:: decorators

Kevin Funk noreply at phabricator.kde.org
Tue Nov 21 11:10:50 UTC 2017


kfunk added inline comments.

INLINE COMMENTS

> kjobwidgets.cpp:67
> +    if (window) {
> +        job->setProperty("window-id", QVariant::fromValue(qptrdiff(window->winId())));
> +    }

`WId` is a `quintptr`: `src/gui/kernel/qwindowdefs.h:99:typedef QT_PREPEND_NAMESPACE(quintptr) WId;`

Besides: `QVariant::fromValue(window->winId())` should work just fine, or?

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D8923

To: apol, #frameworks
Cc: kfunk
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171121/e5454828/attachment.html>


More information about the Kde-frameworks-devel mailing list