D8908: KDateComboBox: fix dateChanged() not emitted after typing a date

David Faure noreply at phabricator.kde.org
Mon Nov 20 08:25:10 UTC 2017


dfaure added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kdatecombobox.cpp:350-351
> Why not
> 
>   d->enterDate(date());
> 
> ?

Good point, `enterDate()` enables the warning-on-invalid when this option is set, and I suppose we want that on Key_Return as well.
However I still need to emit `dateChanged()`, since `setDate()` doesn't do that in this case (it thinks the date hasn't changed, given that we're calling `setDate(date())`).

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8908

To: dfaure, cfeck, dvratil
Cc: anthonyfieroni, #frameworks, #kde_pim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171120/347ef255/attachment.html>


More information about the Kde-frameworks-devel mailing list