D8908: KDateComboBox: fix dateChanged() not emitted after typing a date

[David Faure]

dfaure created this revision.
dfaure added reviewers: cfeck, dvratil.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  When editing an event in korganizer, if I was typing digits
  to edit a date, rather than using another method (date popup; key_up;
  etc.), then the change wouldn't be saved.
  
  I would say that on focus-out or Key_Enter, we want to "commit"
  the edited date into the final date as desired by the user, by emitting
  dateEntered() and dateChanged(), to match the other edit methods.
  
  The documentation clarifies what I think was the intent of the 3
  signals, and the unittest checks that the signals are emitted
  accordingly.
  
  BUG: 364200

TEST PLAN
  Unittest passes; korganizer use case is fixed.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8908

AFFECTED FILES
  autotests/kdatecomboboxtest.cpp
  autotests/kdatecomboboxtest.h
  src/kdatecombobox.cpp
  src/kdatecombobox.h

To: dfaure, cfeck, dvratil
Cc: #frameworks, #kde_pim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171119/eb0562cf/attachment-0001.html>