D8809: Reduce spurious signal emissions

David Edmundson noreply at phabricator.kde.org
Thu Nov 16 14:56:27 UTC 2017


davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> framesvgitem.cpp:295
> +
> +    const QVector<qreal> m_oldMargins;
> +    FrameSvgItemMargins *const m_margins;

If we always have 4 and can initialised them to 0 qreal[4] with a c style array would be better.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8809

To: apol, #plasma, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171116/d633e49e/attachment.html>


More information about the Kde-frameworks-devel mailing list