D8836: Fix KIO::mkpath with qtbase 5.10 beta 4
David Faure
noreply at phabricator.kde.org
Thu Nov 16 10:28:33 UTC 2017
dfaure added inline comments.
INLINE COMMENTS
> mkpathjob.cpp:46
> for (; i < basePathComponents.count() && i < m_pathComponents.count(); ++i) {
> if (m_pathComponents.at(i) == basePathComponents.at(i)) {
> + if (m_url.path() == QLatin1Char('/')) {
I think it's time to put m_pathComponents.at(i) into a local variable ;-)
> mkpathjob.cpp:65
> + QString testDir;
> + if (m_url.toLocalFile() == QLatin1Char('/')) {
> + testDir = m_url.toLocalFile() + m_pathComponents.at(i);
same here with m_url.toLocalFile()
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8836
To: elvisangelaccio, #frameworks, dfaure, thiago
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171116/56b9d558/attachment.html>
More information about the Kde-frameworks-devel
mailing list