D8348: Add a section for removable devices

Renato Oliveira Filho noreply at phabricator.kde.org
Wed Nov 15 13:42:59 UTC 2017


renatoo added inline comments.

INLINE COMMENTS

> mwolff wrote in kfileplacesitem.cpp:91
> shouldn't this always be called? i.e. when the bookmark is changed to a different UDI, don't we need to update here, even when we had a valid device UDI before? I think this also means this path isn't unit tested yet

Changed the code to always check for udi changes. 
I tried to implement a unit test for this case, but I could not find a way to simulate it, and manual updating the bookmark udi cases the model to create a new item since uid is used as id for the model items.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171115/397b5ea6/attachment.html>


More information about the Kde-frameworks-devel mailing list