D8811: [knewstuff] Do not leak ImageLoader on error

[Dan Leinir Turthra Jensen]

leinir added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in engine.cpp:536
> Job can be nullptr, so signal can be a text, it can capture entry by reference?

i guess you could extend the signal further with the error text added in instead of capturing l in the lambda, yes

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D8811

To: anthonyfieroni, leinir, dfaure
Cc: broulik, #frameworks, ZrenBot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171115/ebb6daab/attachment-0001.html>