D8811: [knewstuff] Do not leak ImageLoader on error

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> broulik wrote in engine.cpp:536
> You're copying `entry` into the lambda just for a debug.

If / when someone want to read debug messages, they will be consistent.

> broulik wrote in imageloader_p.h:59
> Why have this argument if you're not naming it and not using it?

It can be an entry and/or type?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D8811

To: anthonyfieroni, leinir, dfaure
Cc: broulik, #frameworks, ZrenBot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171114/30006028/attachment.html>