D8811: [knewstuff] Do not leak ImageLoader on error

Tue Nov 14 05:47:38 UTC 2017

anthonyfieroni created this revision.
anthonyfieroni added reviewers: leinir, dfaure.
anthonyfieroni added a project: KNewStuff.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  1. Notify engine to not observe image preview any more on error codition
  2. Shutdown image loader, HTTP job simultaneously on error condition

TEST PLAN
  We shouldn't restart image loader on error condition, no ?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D8811

AFFECTED FILES
  src/core/engine.cpp
  src/core/imageloader.cpp
  src/core/imageloader_p.h

To: anthonyfieroni, leinir, dfaure
Cc: #frameworks, ZrenBot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171114/c4365d1c/attachment.html>