D8773: Improve discoverability of drag-and-drop of toolbar actions

[Aleix Pol Gonzalez]

apol added a comment.


  Won't un/locking already change the fact that they can be dragged? Or what is it going to become draggable?

INLINE COMMENTS

> ktoolbar.cpp:410
>  
> +        contextEditableAction.reset(new KToggleAction(QIcon::fromTheme(QStringLiteral("document-edit")), i18nc("@item:inmenu", "Draggable Toolbar Actions"), q));
> +        contextEditableAction->setChecked(q->toolBarsEditable());

Isn't it better to set a parent like for the other ona than use the QScopedPointer?

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D8773

To: elvisangelaccio, #frameworks, #vdg, dfaure
Cc: apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171112/a8d4ea71/attachment.html>