D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> simgunz wrote in kopenwithdialog.cpp:463
> Segmentation fault happens if I use the member var. Accessing the member var is the cause of the fault, because even `qDebug() << d->m_proxyModel` generates the same error. It is not clear to me why.

Please try moving that code inside `if (d->appModel) { ... }`.

> simgunz wrote in kopenwithdialog.cpp:1108
> Yes, the cascade of return false doesn't make sense. You mean calling eventFilter of QDialog instead of returning false at the end? eventFilter of QDialog is virtual.

Yes.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx
Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171108/7092a9ef/attachment.html>