D8546: Add Aztec code generator

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:20
> +target_link_libraries(prison-reedsolomontest Qt5::Test KF5::Prison)
> +add_test(NAME prison-reedsolomontest COMMAND prison-reedsolomontest)

I suggest using ecm_add_test

> aztecbarcodetest.cpp:160
> +
> +    void testComaptGrid()
> +    {

typo for Compact?

> aztecbarcode.cpp:734
> +                    break;
> +                if (*it)
> +                    p.drawPoint(x, y);

missing {...} on single-line statements (repeats)

> reedsolomon_p.h:27
>  
> -#include "prison.h"
> -#include "datamatrixbarcode.h"
> -#include "qrcodebarcode.h"
> -#include "code39barcode.h"
> -#include "code93barcode.h"
> +#ifndef PRISON_REEDSOLOMON_H
> +#define PRISON_REEDSOLOMON_H

_P_H to match the filename

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D8546

To: vkrause, #frameworks, svuorela, dfaure
Cc: dfaure, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171106/c2cfe8ea/attachment.html>