D8671: KEmoticons: port plugins to JSON and add support for loading with KPluginMetaData

[Aleix Pol Gonzalez]

apol added a comment.


  Other than that +1

INLINE COMMENTS

> CMakeLists.txt:19
>  )
> -set_target_properties(emoticonstheme_adium PROPERTIES LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin/kf5/emoticonsthemes")
> -install(
> -    TARGETS emoticonstheme_adium
> -    DESTINATION ${KDE_INSTALL_PLUGINDIR}/kf5/emoticonsthemes
> -)
> +# KF6: remove
>  install(

Why do we need to keep them?

Whoever uses this it will be with the new version of the library as well.

REPOSITORY
  R301 KEmoticons

REVISION DETAIL
  https://phabricator.kde.org/D8671

To: dfaure, #frameworks
Cc: apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171106/d462b4d7/attachment-0001.html>