D8643: Fix display of remote:/ in the qfiledialog

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> kfileitem.cpp:559
>      d->m_strName = name;
> -    d->m_strText = KIO::decodeFileName(d->m_strName);
> +    if (!d->m_entry.contains(KIO::UDSEntry::UDS_DISPLAY_NAME)) {
> +        d->m_strText = KIO::decodeFileName(d->m_strName);

Wouldn't it be safer to say if (!name.isEmpty()), for the actual bug you were experiencing?

Otherwise I'm afraid that this commit breaks a number of things, like after renaming a file, the new name doesn't appear because the old "display name" still applies, or the documented use case for setName which is kfind wanting to display subdir/subsubdir/file.txt (same issue, UDS_DISPLAY_NAME would prevent that from working).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8643

To: apol, #frameworks, davidedmundson
Cc: dfaure, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171105/f39eeb72/attachment.html>