D8639: Optimize SortFilterModel role names

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  - Reserve m_roleIds
  - Avoid double lookup contains+value but use default value argument

TEST PLAN
  I don't get why in `syncRoleNames` we populate `m_roleIds` from `roleNames()` but then set roles to `sourceModel()->roleNames()`.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D8639

AFFECTED FILES
  src/declarativeimports/core/datamodel.cpp
  src/declarativeimports/core/datamodel.h

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171103/831c7484/attachment.html>