D8544: KTextEditor : avoiding QML crashes

René J.V. Bertin noreply at phabricator.kde.org
Thu Nov 2 17:17:06 UTC 2017


rjvbb marked 2 inline comments as done.
rjvbb added inline comments.

INLINE COMMENTS

> kfunk wrote in kateglobal.cpp:106
> Minor: "... set to 1" would be sufficient. You're setting it yourself right before, so you can presume it is set (=> no need for `qgetenv(...)`.

I know that of course, but figured that if I was adding a debug output I could just as well have it verify that we got what we asked for.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D8544

To: rjvbb, #frameworks
Cc: kfunk, dhaumann, cullmann, kde-frameworks-devel, kevinapavew, demsking, head7, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171102/306231a6/attachment.html>


More information about the Kde-frameworks-devel mailing list