D8544: KTextEditor : avoiding QML crashes

[Kevin Funk]

kfunk added inline comments.

INLINE COMMENTS

> kateglobal.cpp:104
> +    // disable the QML JIT compiler as a protection against an unknown bug
> +    // in Qt's V4 engine which can provoke a crash in certain of our scripts.
> +    qputenv("QV4_FORCE_INTERPRETER", QByteArrayLiteral("1"));

Please add a reference to the bug reports (Qt JIRA, KDE Bugzilla) here.

> kateglobal.cpp:106
> +    qputenv("QV4_FORCE_INTERPRETER", QByteArrayLiteral("1"));
> +    qCDebug(LOG_KTE) << "QV4_FORCE_INTERPRETER set to" << qgetenv("QV4_FORCE_INTERPRETER");
> +#endif

Minor: "... set to 1" would be sufficient. You're setting it yourself right before, so you can presume it is set (=> no need for `qgetenv(...)`.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D8544

To: rjvbb, #frameworks
Cc: kfunk, dhaumann, cullmann, kde-frameworks-devel, kevinapavew, demsking, head7, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171102/c549d5af/attachment.html>