D8434: Created 'remote' section

[Milian Wolff]

mwolff added inline comments.

INLINE COMMENTS

> kfileplacesmodeltest.cpp:784
> +    // insert a new network url
> +    m_places->addPlace(QStringLiteral("My Shared"), QUrl( QStringLiteral("ftp://192.168.1.1/ftp")), QString(), QString(), QModelIndex());
> +

please add URLs for the following schemas, too:

smb
sftp
fish
webdav

> kfileplacesitem_p.h:48
>          PlacesType = 0,
> -        RecentlySavedType = 1,
> -        SearchForType = 2,
> -        DevicesType = 3,
> -        RemovableDevicesType = 4
> +        NetworkType = 1,
> +        RecentlySavedType = 2,

this should probably also be called `RemoteType` now, no?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8434

To: renatoo, ngraham, #frameworks, #dolphin
Cc: elvisangelaccio, mwolff, mlaurent, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171101/f748233c/attachment.html>