D6041: Port a bunch of classes away from Plasma::Package

[Marco Martin]

mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> pluginloader.h:208
> +     **/
> +    PLASMA_DEPRECATED KPluginInfo::List listAppletInfoForMimeType(const QString &mimetype);
> +

wow, phab isn't that smart in the diff it makes checking for binary compatibility quite tricky ;)

> appletquickitem.h:105
>  
> -    Plasma::Package appletPackage() const;
> -    void setAppletPackage(const Plasma::Package &package);
> +    KPackage::Package appletPackage() const;
> +    void setAppletPackage(const KPackage::Package &package);

despite the warning in the header, this ended up being an exported symbol, so binary compatibility rules apply here too.
Plasma::Package appletPackage() const; has to stay, eventually deprecated and a new KPackage::Package appletPackage() const; added.

> wallpaperinterface.h:26
>  
> -#include <Plasma/Package>
> +#include <plasma/plasma_export.h>
> +#include <KPackage/Package>

why plasma_export.h?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6041

To: apol, #frameworks, #plasma, mart
Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170531/9d96163f/attachment.html>