D6017: Don't leak MimeData object

David Edmundson noreply at phabricator.kde.org
Mon May 29 21:34:58 UTC 2017


davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  A DeclarativeDropArea creates a new DeclarativeDragDropEvent on every
  enter/move/leave event.
  
  The getter method for the mimeData property creates a new MimeData
  QObject wrapper, which then leaks.
  
  Use of the mimeData object outside of the event shouldn't be expected to
  work, and a quick grep couldn't find any usage.
  
  BUG: 380270

TEST PLAN
  Dragged some things

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6017

AFFECTED FILES
  src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.cpp
  src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.h

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170529/70a1aea4/attachment.html>


More information about the Kde-frameworks-devel mailing list