Compilation failure on Windows: kpeople

[Ralf Habacker]

Am 27.05.2017 um 23:31 schrieb Ben Cooksley:

> On Wed, May 17, 2017 at 7:33 AM, Ralf Habacker <ralf.habacker at freenet.de> wrote:
>> Hi
>>> When someone gets the chance, could they please look into the build
>>> log at https://build-sandbox.kde.org/job/Frameworks%20kpeople%20kf5-qt5%20WindowsQt5.7/4/console
>>> to see why this Framework isn't building on Windows?
>> from my recent experience with building kmymoney on Windows this may be
>> caused by compiling code using a class located in a different shared
>> library and therefore declared as dllimport, but  later included in the
>> same dll as static library.
>>
>> I dealed with this by undefining the related export macro as target
>> definition [1]. Something like this
>>
>> +if( WIN32 )
>> +  target_compile_definitions(reports PUBLIC KMM_MYMONEY_EXPORT=)
>> +endif()
> Sorry, i've only just now had time to take a look into this.
>
> As it turns out Pino fixed the build of kpeople in
> https://cgit.kde.org/kpeople.git/commit/?id=dde883a272208ad4e3d01c223cd4ea59a0ae856d
It is indeed the same reason and has been fixed in the same way by
removing KPEOPLE_EXPORT.
Ralf