D5877: Do not watch QRC's paths

David Faure noreply at phabricator.kde.org
Sun May 21 17:17:19 UTC 2017


dfaure added a comment.


  Looks good otherwise.

INLINE COMMENTS

> kdirwatch_unittest.cpp:760
> +    watch.addDir(QDir::homePath());
> +    // NOTE: addDir(".") it's not enough, we really need this path to trigger bug #374075.
> +    watch.addDir(QStringLiteral(":/kio5/newfile-templates"));

Isn't this comment outdated now that the test and the fix are all about qrc paths rather than "." ?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D5877

To: elvisangelaccio, dfaure
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170521/85413fa8/attachment.html>


More information about the Kde-frameworks-devel mailing list