D5872: pidChanged also signals dataChanged in WindowModel

[Martin Flöser]

graesslin added a comment.


  In https://phabricator.kde.org/D5872#109962, @hein wrote:
  
  > I'm fine with no change signal, but heads-up that libtaskmanager has code connecting to it, so if you remove it from kwayland please also adapt plasma-workspace or the build breaks.
  
  
  I highly suggest to remove that. That signal doesn't work as there is no change going to happen. It's just pointless.
  
  Anyway I want a solution on this broken test ASAP. I don't have the time to code a fix for it, but I want KWayland to be green prior to me leaving to vacations. Just adding the changed signal to fix the test is not acceptable as that would mean we have an incorrect API added which we cannot remove till KF 6.
  
  If it has to be I'm going to revert the changes - even if it makes other software break compilation.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5872

To: sebas, #plasma, hein, davidedmundson
Cc: graesslin, bshah, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170516/8db101b7/attachment.html>