Review Request 130128: Remove HelperProxy::authorizeAction

Aleix Pol Gonzalez aleixpol at kde.org
Sun May 14 22:26:04 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130128/#review103213
-----------------------------------------------------------


Ship it!




Ship It!

- Aleix Pol Gonzalez


On mai. 14, 2017, 11:50 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130128/
> -----------------------------------------------------------
> 
> (Updated mai. 14, 2017, 11:50 p.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Repository: kauth
> 
> 
> Description
> -------
> 
> It's not called anywhere
> 
> 
> And thus is distracting to have the code when you're trying to figure out how all this thing works.
> 
> 
> Diffs
> -----
> 
>   src/HelperProxy.h 0439651 
>   src/backends/dbus/DBusHelperProxy.h 82cec5a 
>   src/backends/dbus/DBusHelperProxy.cpp 3c1c108 
>   src/backends/dbus/org.kde.kf5auth.xml 3134375 
>   src/backends/fakehelper/FakeHelperProxy.h 63df829 
>   src/backends/fakehelper/FakeHelperProxy.cpp 6000c37 
> 
> Diff: https://git.reviewboard.kde.org/r/130128/diff/
> 
> 
> Testing
> -------
> 
> It compiles
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170514/af9da1eb/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list