D5851: Fix the PID updated in PlasmaWindowedModel

Martin Flöser noreply at phabricator.kde.org
Sun May 14 16:59:44 UTC 2017


graesslin added a comment.


  In https://phabricator.kde.org/D5851#109478, @davidedmundson wrote:
  
  > It makes absolutely no sense to have a pidChanged signal and then say clients shouldn't be using it.
  >
  > Either window has no reason to have a pidChanged signal or we should connect to it. It has to be one or the other.
  
  
  Right, the signal shouldn't exist. I overlooked that in the other review. Sorry. I pointed it out in two cases and missed the third. The signal should be removed IMHO.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5851

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170514/38cded8b/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list